Make: Support CFLAGS as both env var and make argument #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
make-arg-cflags
branch
from
d7e99b5 to
ccf56b1
Compare
We usually pass arguments to make through environment variables: CFLAGS="-std=c11" make quickcheck It currently does not work to pass it as a make argument: make quickcheck CFLAGS="-std=c11" This commit fixes that and extends the C90 CI to test both variants. Resolves #722 Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
hanno-becker
force-pushed
the
make-arg-cflags
branch
from
ccf56b1 to
cfe151f
Compare
hanno-becker
previously approved these changes
Nov 21, 2025
hanno-becker
dismissed
their stale review
Missed that this PR was not in line with its sibling on mlkem-native
hanno-becker
requested changes
Nov 21, 2025
Contributor
There was a problem hiding this comment.
Can you update this in line with pq-code-package/mlkem-native#1316?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually pass arguments to make through environment variables: CFLAGS="-std=c11" make quickcheck
It currently does not work to pass it as a make argument: make quickcheck CFLAGS="-std=c11"
This commit fixes that and extends the C90 CI to test both variants.
I stapled on a cleanup of the Makefiles to align with mlkem-native